Add lighting menu for kbd67mkiirgb v3 - #2582
Open
SEApodEErman wants to merge 1 commit into
Open
SEApodEErman wants to merge 1 commit into
SEApodEErman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the missing menus block to v3/kbdfans/kbd67mkii/kbd67mkiirgbv3.json for lighting menu support.
Current V3 definitions had no menus for lighting since the last time an issue was made for it (#1131) was when VIA's lighting UI did not support per-key RGB/RGB Matrix at that time and was understandably closed.
The reason I went with a custom menu instead of
"menus": ["qmk_rgb_matrix"]was due to the QMK source firmware only compiling 26 of the RGB Matrix animations. The uncompiled effects shift every later mode down and the built-in menu assumes the full effect order (at least in my testing). This would cause the dropdown to mislabel entries and address nonexistent modes on this board and Custom UI specification seems to support this.Do note that I only specify kbd67mkiirgb v3 since it's the only PCB I own, I'm unsure how other versions would react to the changes.
QMK Pull Request
qmk/qmk_firmware#13714
VIA Keymap Pull Request
qmk/qmk_firmware#8085
(PR was made for v1/v2 but in the current userspace repository, this seems to apply to all kbd67mkiirgb versions.)
Checklist
qmk_lightingmodule.0xFEED