Repository navigation
hexagon: preserve partial quantized REPACK transfers - #146
Merged
Merged
Conversation
Merged
1 task done
GustavoA1604
approved these changes
Nov 3, 2026
mexxik
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error corrected
On SM8750/v79, an opt-in non-HOSTBUF Q8_0 128×33 buffer accepted a 136-byte transfer but its repacker processed the entire 4,488-byte tensor. A short GET overwrote the sentinel tail of the caller's full-size diagnostic buffer; a short SET changed rows outside the requested range. The safe baseline diagnostic exited 1. The corrected package preserves both tails and exits 0. The default HOSTBUF=1 path remains unchanged.
Validation
speech@de1d0f5cAndroid host/v79 DSP package: 15/15 device hashes match before and after.git diff --checkpasses; independent source review found no blocking issue.Partial SET now uses a temporary canonical tensor and full untile/retile, so frequent partial updates can cost memory and time; complete transfers retain the original path. These checks do not establish whole-model parity or a performance improvement.
Audit subtask: https://app.asana.com/1/45238840754660/project/1214153063536860/task/1220036025374365