I1 [DOCS/build] Distribution readiness — --version fallback + release.yml + README quickstart#34
Merged
Merged
Conversation
…tall builds report a real version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three pieces of distribution prep gating the v0.x.0 cut:
shithub --versionprinteddev (unknown) built unknownfrom any build that didn't go through the Makefile (notablygo install github.com/.../cmd/shithub@vX.Y.Z). Addedbuild.Resolved()which prefers the ldflags-set values (Make/goreleaser path) and falls back toruntime/debug.ReadBuildInfo()forgo install-style builds. After v0.1.0 tags,go install ...@v0.1.0will reportshithub 0.1.0 (a1b2c3d4) built 2026-…instead of the dev sentinels..github/workflows/release.ymlso tag-push automatically runs goreleaser. Pinsgoreleaser-action@v6withversion: '~> v2'so we track v2 patch updates without unattended major bumps. Includes amake build && ./bin/shithub --versionsmoke step before goreleaser fires, so a broken ldflags chain fails fast before artifacts upload.go installpath, browser--webauth flow, daily-driver verbs (pr list,pr view,pr checkout,issue create,repo view --web), and a "differences from gh" section.Test plan
TestResolvedFallsBackToBuildInfo— verifies the fallback returns VCS metadata when debug.ReadBuildInfo provides it. Skips gracefully when VCS info isn't available (test-binary edge case).TestPrintVersionHuman+TestPrintVersionJSONupdated to source frombuild.Resolved()so the assertion accounts for the enrichment.make ciclean (build + test + lint + fmt-check + vet + spdx-check + ci-windows leg unchanged).v0.0.1-rc.0tag in a fork and confirmsrelease.ymlproduces the goreleaser artifacts.go install github.com/tenseleyFlow/shithub-cli/cmd/shithub@HEADafter this merges and confirmsshithub --versionreports the commit short-sha (not "unknown").Notes / deferred
brew install tenseleyFlow/tap/shithubbut the tap itself ships in C25 (Distribution sprint). The README is honest about this — the v0.x.0+ section is gated on C25.-buildvcs=autodoesn't followgitdir:pointers from a worktree's.gitfile, so a binary built directly from a worktree still showsdev (unknown) built unknown. Doesn't affect production paths (go install, fresh clone, goreleaser CI all work correctly).Once this lands, I7a (server response shape) becomes the critical path.