H13 [MED/CLI] --body / --body-file mutex across all body-bearing commands (H16)#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes H16 — and audits the rest of the body-bearing surface for the same shape. Pre-fix passing both
--body "X"and--body-file pathsilently used the file and discarded the inline content; users had no signal their typo was a no-op. gh-compat refuses the combination at parse.Applied
cmd.MarkFlagsMutuallyExclusive("body", "body-file")at every site that exposes both flags:pr edit,issue editpr create,issue createpr comment,issue commentpr reviewpr mergeError message comes from cobra:
if any flags in the group [body body-file] are set none of the others can be; [body body-file] were all set. Stable and self-explanatory.The internal
readBodyFile(path, fallback, ...)helpers still pick file over inline when both fields are populated programmatically (existing tests likeTestCreateBodyFileWinscover that path). The mutex sits in front at the cobra layer — directRun(opts)callers (tests, library users) keep the precedence behavior; CLI users get the error.Test plan
TestEditRejectsBodyPlusBodyFile(pr/edit) — cobra-level mutex firesTestCreateBodyFileWinsetc.) still pass — they callRun(opts)directly, bypassing cobramake cicleanshithub pr edit 1 -R o/r --body x --body-file /tmp/y— expect parse error referencing both flags