Conversation
✅ Changelog found on PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f261f1a42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let Some(err) = classify_tx_error(&original) { | ||
| return Err(err); | ||
| } |
There was a problem hiding this comment.
Do not skip key-authorization retry on classified errors
This early return bypasses the with_key_authorization() retry path whenever the first optimistic RPC error is recognized (e.g., spending-limit selector or revoked). That retry is the mechanism that atomically applies stored key authorization, so wallets with stale on-chain key state (for example right after tempo wallet refresh) can now fail permanently in a case that was previously recoverable by retrying with attached authorization. The same pattern appears again in submit_tempo_tx, so both estimation and broadcast paths lose the auto-provisioning behavior.
Useful? React with 👍 / 👎.
Summary
0x8a9e71ea/SpendingLimitExceededinto a payment error with a wallet-specific hint