Skip to content

Refactor Python conversion process to prompt for output file selection within the conversion function - #333

Merged
jharajeev55 merged 4 commits into
release/v1.5.2from
fix/TSP-1997-handle-calling-python-wrapper-command
Sep 11, 2026
Merged

jharajeev55 merged 4 commits into
release/v1.5.2from
fix/TSP-1997-handle-calling-python-wrapper-command

Conversation

@jharajeev55

Copy link
Copy Markdown
Contributor

Resolves: TSP-1997

@jharajeev55 jharajeev55 self-assigned this Sep 10, 2026
@jharajeev55 jharajeev55 added the bug Something isn't working label Sep 10, 2026
@jharajeev55
jharajeev55 marked this pull request as ready for review September 10, 2026 06:46
@jharajeev55
jharajeev55 requested a review from a team as a code owner September 10, 2026 06:46

@suribabu-ganti suribabu-ganti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the current implementation: it performs the conversion before showing the save dialog. If the user cancels, the conversion work was unnecessary.

Comment thread src/extension.ts
Comment thread src/tspConverter.ts
@jharajeev55

Copy link
Copy Markdown
Contributor Author

with the current implementation: it performs the conversion before showing the save dialog. If the user cancels, the conversion work was unnecessary.

In current flow conversion is happening after the file selection,

Comment thread src/tspConverter.ts
@jharajeev55
jharajeev55 requested a review from esarver September 11, 2026 13:37
@jharajeev55
jharajeev55 merged commit 51e9c2d into release/v1.5.2 Sep 11, 2026
13 of 14 checks passed
@jharajeev55
jharajeev55 deleted the fix/TSP-1997-handle-calling-python-wrapper-command branch September 11, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants