Repository navigation
Add coverage for number conversion in JSON.stringify and Array.p.join - #5145
Merged
Merged
Conversation
There was minimal coverage of Number values in these functions, except that JSON.stringify had coverage for -0 and infinities/NaNs. This coverage would be helpful for some optimizations I'm working on. LLM disclosure: I used a bot to make a first draft of these tests, which I then edited to be more readable and to-the-point.
|
2 new or modified tests were run on 7 engines.
|
Ms2ger
approved these changes
Oct 8, 2026
Ms2ger
left a comment
Ms2ger
left a comment
Contributor
There was a problem hiding this comment.
Sure, why not. TIL that NaN and infinities serialize to "null" in JSON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was minimal coverage of Number values in these functions, except that JSON.stringify had coverage for -0 and infinities/NaNs. This coverage would be helpful for some optimizations I'm working on.
LLM disclosure: I used a bot to make a first draft of these tests, which I then edited to be more readable and to-the-point.