Repository navigation
Conversation
nicolo-ribaudo
approved these changes
Jul 24, 2026
| if (text === '*undefined*') { | ||
| return { kind: 'undefined' }; | ||
| } | ||
| break; |
Member
There was a problem hiding this comment.
I'd rather put the unknown-non-enum case here and leave the final fall-through as unknown. Related, this switch is nearly exhaustive, it just doesn't contain record, which we have a type for. We should add it (either as part of this PR or not, don't care) to make it both more complete and easier to understand.
Member
|
I'm a bit skeptical that we won't ever want to alias a union that includes an enum, but I'm willing to give it a shot. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type lattice is deliberately conservative; when it encounters a type name it doesn't recognize, like
PrivateElement, it assumes that could hold anything and as such it is never an error to assign any value to something of that type.This heuristic is generally necessary; e.g. a property key is a String or a Symbol, and "property key" is an unknown type, so it is good that ecmarkup does not regard it as an error to assign a String to an unknown type.
However, we don't and (I weakly believe) shouldn't define any types that hold enums. This means we can assume a type name we don't recognize cannot hold an enum, and so assigning an enum specifically to such a type is an error.