Skip to content

Table and Figure caption styles - #664

Open
gesa wants to merge 5 commits into
tc39:mainfrom
gesa:figure-styles
Open

gesa wants to merge 5 commits into
tc39:mainfrom
gesa:figure-styles

Conversation

@gesa

@gesa gesa commented Nov 13, 2025

Copy link
Copy Markdown
Member

Updated to Ecma house style.

  • Update css to align with template
  • Replace : with —
  • Begin re-numbering figures at the beginning of each annex (as A1, A2, etc)

Comment thread src/Figure.ts Outdated

@michaelficarra michaelficarra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it, but okay.

@gesa

gesa commented Nov 13, 2025

Copy link
Copy Markdown
Member Author

I don't like it, but okay.

@michaelficarra I would be delighted to come at the numbering with a different approach. I also don't like it, at least not the solution I'm proposing. I just couldn't think of anything better.

I found a mismatch in the layout as compared to the template reviewing this—figure captions should render below the figure, table captions should render above the table. Commit resolving this incoming.

@gesa
gesa requested a review from michaelficarra November 14, 2025 06:36
Comment thread src/Figure.ts Outdated
Comment thread src/Clause.ts
Comment on lines +114 to +119
// Reset figure numbering for each Annex
if (this.isAnnex && !this.parentClause) {
spec._figureCounts.figure = 0;
spec._figureCounts.table = 0;
spec._figurePrefix = `${number}.`;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the rendering of <emu-xref>, e.g. "The entries in Table 103 are added to Table 6" at B.2.1 Additional Properties of the Global Object becomes "The entries in Table 1 are added to Table 6" rather than "The entries in Table B.1 are added to Table 6".

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed like a suspiciously easy fix. The figure biblio entries expect a number or a string, so I modified the prefix to be added at that point in the figure generation.

@gesa
gesa requested a review from gibson042 September 24, 2026 17:11

@gibson042 gibson042 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants