Skip to content

fix(android): log and clear webview creation errors #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tomatotomata wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix(android): log and clear webview creation errors #1803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/android/binding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,15 @@ pub unsafe fn onFirstActivityCreateWry(env: JNIEnv, _: JClass) {
if libc::read(fd.as_raw_fd(), buf.as_mut_ptr() as *mut _, buf.len())
== buf.len() as libc::ssize_t
{
// unregister itself on errors
main_pipe.recv().is_ok()
match main_pipe.recv() {
Ok(()) => true,
Err(_error) => {
#[cfg(feature = "tracing")]
tracing::error!("Failed to process Android main pipe message: {_error}");
let _ = main_pipe.env.exception_clear();
false
}
}
} else {
// unregister itself
false
Expand Down
Loading