Fix empty place suggestion titles for plain addresses (Nominatim provider)#65
Open
iamnothardcoded wants to merge 1 commit into
Open
Conversation
Nominatim's 'name' field is only populated for named POIs; plain street addresses (e.g. house-number results) return an empty name. The suggestion title therefore rendered blank, and themes that write the selected suggestion's title back into their search query (e.g. ti-theme-orange's SearchesNearby::onSelectSuggestion) end up with an empty query — the fulfillment confirm then silently skips storing the delivery position and checkout reports no delivery address. Fall back to display_name, which is guaranteed non-empty and re-geocodable.
iamnothardcoded
added a commit
to iamnothardcoded/tastyrhodos
that referenced
this pull request
Jul 15, 2026
…e#65 Removal instructions in the class docblock + CLAUDE.md TODO. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
NominatimProvider::placesAutocomplete()maps the suggestion title from Nominatim'snamefield:Nominatim only populates
namefor named POIs (restaurants, landmarks). For plain street addresses — which is what delivery customers type —nameis an empty string, so the suggestion title is blank.User-facing impact
In
ti-theme-orange,SearchesNearby::onSelectSuggestion()writes the selected suggestion's title back intosearchQuery. With a blank title the query becomes empty, andFulfillmentModal::onConfirm()then silently skips the address branch (if ($this->searchQuery && $this->showAddressPicker)) — no validation error, no stored user position. The customer believes they set their delivery address; checkout shows "No delivery address provided".This affects every install using the default/free Nominatim geocoder (no Google API key).
Repro: guest visitor → fulfillment modal → delivery → type a street address with house number (e.g.
Bochumer Str. 76, Castrop-Rauxel) → select the suggestion → input blanks → Confirm → checkout has no delivery address.The fix
Fall back to
display_namewhennameis empty.display_nameis guaranteed non-empty and — being Nominatim's own output — re-geocodes cleanly whenonConfirm()geocodes the title verbatim. Named POIs keep theirnameas before (existing test still passes).Test added; full
NominatimProviderTest+GoogleProviderTestsuite passes (27 assertions).