Crash: java.lang.IllegalArgumentException: activity must not null

[HessiPard]

Hi, thanks for developing this library
After implementation and release to production, we have recieved this type of crash from about 30% of our daily active users:

java.lang.IllegalArgumentException: activity must not null
com.tapligh.sdk.adview.Tapligh.newInstance SourceFile:46 com.tapligh.sdk.reward.reactnative.TaplighReactNativeModule.initialize TaplighReactNativeModule.java:78 com.facebook.react.bridge.ModuleHolder.doInitialize ModuleHolder.java:222 com.facebook.react.bridge.ModuleHolder.markInitializable ModuleHolder.java:97 com.facebook.react.bridge.NativeModuleRegistry.notifyJSInstanceInitialized NativeModuleRegistry.java:102 com.facebook.react.bridge.CatalystInstanceImpl$2.run CatalystInstanceImpl.java:441 android.os.Handler.handleCallback Handler.java:800

Info:
"react": "16.9.0",
"react-native": "0.61.4",
"tapligh-react-native": "3.0.12-1"

[HessiPard]

The main problem is getCurrentActivity() that returns null in TaplighReactNativeModule.initialize

[w1ldworm]

Hi @HessiPard,
Thanks for using Tapligh React Native SDK for your application.
The SDK core is designed to crash if the initial step is called for a null activity. Please check out this thread about the getCurrentActivity method Github. And also please provide some sample code and explain the situation you try to initialize Tapligh.

Thanks

[HessiPard]

It is strange how this crash happens, because we just tested whole devices around us and it looks fine but in production 30 percent of users face this problem.
I just call initialize method in JS after users enter the app.

Tapligh.initialize();
Tapligh.setToken(AppConfig.TAPLIGH_API_KEY, false);

Maybe it's better change the native structure a little bit for example:
1- check for null activity in initialize method like this:

public void initialize() {
    Activity activity = getCurrentActivity();

    if (activity == null) {
	return;
    }
    if (tapligh == null) {
        tapligh = Tapligh.newInstance(activity);
    }
 }

because the structure isn't promise based return nothing is best option i think :)

2-Don't throw error in loadAd(). instead handle initialize once again in loadAd() in case of null tapligh. if initilize fails again just sendMessageToReact(context, ON_LOAD_ERROR_EVENT, map) with specific error, something like this:

public void loadAd(String unitCode){
    if (tapligh == null){
        initialize();
	setToken(api_token, false);
	if (tapligh == null) {
		WritableMap map = Arguments.createMap();
		map.putString(UNIT_CODE_KEY, unitCode);
		map.putString(LOAD_ERROR_STATUS_KEY, "tapligh is null");
		sendMessageToReact(context, ON_LOAD_ERROR_EVENT, map);
		return;
	}
    }
... rest of the code
}

it seems that null getcurrentActivity() was common issue and in this thread people shared their exprience.