Repository navigation
Conversation
…ial injection ### Description This PR reviews and validates the main `tangem-publish.yml` workflow for the `wallet-core` repository, ensuring robust release automation, secure environment handling, and clean artifact lifecycles. ### Key Changes * **Secure Environment-Based Publishing:** - Verified that sensitive Android publishing credentials and build versions are securely passed via environment variables (`GITHUB_USER`, `GITHUB_TOKEN`, `PUBLISH_VERSION`) into Gradle execution[cite: 17]. * **Modern Actions & Artifact Management:** - Utilizes pinned action versions (`actions/checkout@v4`, `actions/upload-artifact@v4`, `actions/download-artifact@v4`) and robust multi-job concurrency controls[cite: 17]. * **Cross-Platform Release Pipelines:** - Seamlessly structures tag creation, iOS build/upload steps with DSYM symbol handling, conditional SwiftProtobuf binary updates, and Android artifact publishing[cite: 17]. ### Validation & Testing * **Workflow Integrity:** Verified successfully against workspace YAML parsing and security guidelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reviews and validates the main
tangem-publish.ymlworkflow for thewallet-corerepository, ensuring robust release automation, secure environment handling, and clean artifact lifecycles.Key Changes
GITHUB_USER,GITHUB_TOKEN,PUBLISH_VERSION) into Gradle execution[cite: 17].actions/checkout@v4,actions/upload-artifact@v4,actions/download-artifact@v4) and robust multi-job concurrency controls[cite: 17].Validation & Testing