fix: resolve all critical Rust clippy linting issues - #808
Open
mridulTripathi wants to merge 4 commits into
Open
fix: resolve all critical Rust clippy linting issues#808mridulTripathi wants to merge 4 commits into
mridulTripathi wants to merge 4 commits into
Conversation
Collaborator
|
If you split the changes to own commits and leave only Arc/WASM/cache changes then I'll merge it |
mridulTripathi
force-pushed
the
fix/linting-issues
branch
2 times, most recently
from
August 24, 2025 09:17
126fe95 to
db55139
Compare
- Fix Arc thread safety issues with proper Send+Sync bounds in lsp-async-stub - Fix WASM thread safety issues with proper Send+Sync implementations This commit contains ONLY the essential Arc/WASM thread safety fixes requested for merge.
- Remove unused method() from Handler trait in lsp-async-stub - Remove unused syntax() method from FormattedItem trait - Clean up trait implementations and improve code organization
- Update format strings to use modern Rust inline syntax (e.g., {variable})
- Apply consistent formatting across taplo, taplo-cli, and formatter modules
- Improve readability and follow Rust best practices
- Fix missing semicolons in comment.ts syntax definitions - Ensure proper TypeScript syntax compliance
mridulTripathi
force-pushed
the
fix/linting-issues
branch
from
August 24, 2025 09:21
db55139 to
cabd068
Compare
Author
|
@panekj, I have broken it down to specific commits. Kindly confirm if this looks good or should I make this even shorter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Rust crates now compile successfully with strict clippy warnings enabled. Tests pass: 101/101
Resolves compilation blocking issues and improves code quality.