Add Xlsx cell style reading support#682
Open
jmcnamara wants to merge 2 commits into
Open
Conversation
Add a `worksheet_style()` API that reads cell formatting (font, fill, borders, alignment, number format, protection) from XLSX files into an RLE-compressed StyleRange, plus a streaming `next_style_id()` on XlsxCellReader. Theme and indexed colors are resolved, including tint. Inspired by PR tafia#653. Co-authored-by: David DiMaria <info@collectivesessions.com>
jmcnamara
changed the title
Add `XlsxCellReader::next_cell_with_style_id()` which returns each cell value together with its style id in a single pass over the worksheet, avoiding a second read when both values and styles are needed. The id resolves to a full `Style` via the reader's `styles()` palette.
jmcnamara
force-pushed
the
xlsx-cell-styles
branch
from
July 15, 2026 14:31
9d26473 to
6ae78e5
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a smaller version of the PR to add XLSX Styles support to Calamine in #653.
Reviewing that PR was difficult because some recent changes to attribute handling meant that it didn't apply cleanly. It also contained changes for Rich Text and Worksheet Layout in a single commit. So in order to review it I simplified it down to the Style additions and rebased it as best I could while making the changes to the code that I would have requested.
I also added a second commit on top of it that reads the cell information and the style in one read, since that is the use case that most people will have:
I will submit another PR on top of this that gives a more comprehensive Cell reader interface.