[DS 2.0] Strip measured node sizes from saved and exported diagrams - #124
Draft
librowski wants to merge 1 commit into
Draft
[DS 2.0] Strip measured node sizes from saved and exported diagrams#124librowski wants to merge 1 commit into
librowski wants to merge 1 commit into
Conversation
librowski
requested review from
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
September 7, 2026 12:05
librowski
marked this pull request as draft
September 7, 2026 12:07
librowski
force-pushed
the
ds2-persist-without-measured
branch
from
September 7, 2026 12:09
11b2648 to
7670612
Compare
Runtime dimensions were persisted alongside the diagram and observed to stay at the stale stored value after remeasurement, so exports and localStorage carried sizes that no longer matched the rendered nodes. Sizes are a runtime fact; nodes are measured again on load.
librowski
force-pushed
the
ds2-persist-without-measured
branch
from
September 7, 2026 12:37
7670612 to
2f783dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getStoreDataForIntegration(used by the localStorage, API and props integrations and by export) stripped onlyselectedfrom nodes, so the runtimemeasuredsizes travelled with the diagram. Observed in the demo: after the node shell width changed, Save still wrote the previousmeasured.width, so persisted data carried sizes that no longer matched the rendered nodes. Nothing in the SDK readsmeasuredback from stored data - nodes are measured again on load.Change
skipDynamicValuesInNodesdropsmeasuredalongside resettingselected; JSDoc ofgetStoreDataForIntegrationlists measured sizes among the stripped runtime values.dynamic-values.spec.tscovers nodes (measured dropped, selection reset, input untouched) and edges (routing points and selection reset).@workflowbuilder/sdkpatch (export format no longer containsmeasured).Fixtures under
apps/still containmeasured; it is now ignored data and can be cleaned up separately.