Conversation
|
Heads-up on the CI result of this PR: with the job now resolving the actual
So this immediately surfaces an incompatibility that the old setup was hiding (it was testing I did not open a separate issue for this, since the red CI here already puts it in front of you on the right thread. How would you prefer to handle it?
Either way works for me. The important part is that the |
|
Coming back to this with the actual cause, my guess above was wrong. The The job had resolved That also means this PR and #695 overlap, @nicolas-grekas: yours sets |
As reported in #687, the
phpunit-devCI job does not actually test against dev dependencies.The job runs
composer config minimum-stability devbefore installing, butcomposer.jsonalready declaresminimum-stability: devtogether withprefer-stable: true. Since dev versions are already allowed, that step is a no-op, andprefer-stable: truemakes Composer install the stable releases anyway.I verified this locally: with the current setup the job resolves
symfony/dom-crawlertov8.1.1(stable), while disablingprefer-stableresolves it to8.2.x-dev. This is what let the Symfony 8 incompatibility from #685 slip through the "dev dependencies" job.This replaces the redundant
minimum-stabilitystep withcomposer config prefer-stable false, so the job resolves the actual*-devversions.Note: since the job only becomes meaningful now, it may surface incompatibilities that were previously hidden. #685 is already fixed, and the sources lint cleanly against the dev versions, but the browser-based tests can only be validated by a real CI run here.