Repository navigation
Close handlers through kernel.reset on Symfony 8.2 - #588
Open
nicolas-grekas wants to merge 1 commit into
Open
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
GromNaN
approved these changes
Oct 13, 2026
nicolas-grekas
marked this pull request as ready for review
October 15, 2026 14:46
nicolas-grekas
marked this pull request as draft
October 15, 2026 17:23
Member
Author
|
Back to draft: we plan a |
nicolas-grekas
force-pushed
the
drop-handler-lifecycle-manager
branch
from
October 16, 2026 14:20
323eb51 to
f160e52
Compare
nicolas-grekas
changed the title
kernel.reset on Symfony 8.2
nicolas-grekas
marked this pull request as ready for review
October 16, 2026 14:21
stof
reviewed
Oct 16, 2026
Member
Author
|
Ready for review and merge again now that symfony/symfony#67018 is merged. |
HypeMC
approved these changes
Oct 16, 2026
nicolas-grekas
force-pushed
the
drop-handler-lifecycle-manager
branch
from
October 16, 2026 17:38
03b4b9b to
27573e0
Compare
stof
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags handlers with
on_shutdown: onlyfrom symfony/symfony#67047 to close them when the kernel shuts down. Older Symfony versions keep the existing lifecycle manager and shutdown hook and dependency constraints.