Skip to content

[Concurrency] Make EmbeddedPlatformSingleThreaded debugger-friendly - #92513

Open
felipepiovezan wants to merge 1 commit into
swiftlang:mainfrom
felipepiovezan:felipe/embeddedplatformsinglethreaded_debugger_friendlty
Open

felipepiovezan wants to merge 1 commit into
swiftlang:mainfrom
felipepiovezan:felipe/embeddedplatformsinglethreaded_debugger_friendlty

Conversation

@felipepiovezan

Copy link
Copy Markdown
Contributor

This platform needs to export the name of its global array of pointers, as well as define its storage kind so that the debugger knows what it is inspecting.

Note: the initialization of the array had to be changed to a plain [null, null....] list, as silgen_name requires a constant initializer.

This platform needs to export the name of its global array of pointers,
as well as define its storage kind so that the debugger knows what it is
inspecting.

Note: the initialization of the array had to be changed to a plain
[null, null....] list, as silgen_name requires a constant initializer.
@felipepiovezan

Copy link
Copy Markdown
Contributor Author

@gonzalolarralde

@gonzalolarralde gonzalolarralde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! I'll continue with the other methods we discussed on the thread early next week :)

// See ConcurrencyDebug.h
@used
@_silgen_name("_swift_concurrency_debug_current_task_storage_kind")
public let _swift_concurrency_debug_current_task_storage_kind: UInt32 = 5

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mentioning SWIFT_CONCURRENCY_CURRENT_TASK_STORAGE_KIND_GLOBAL_TLS_ARRAY in a comment here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants