[DeadObjectElimination] Handle MarkDependenceAddr as its own Access kind - #92510
Open
aidan-hall wants to merge 1 commit into
Open
aidan-hall wants to merge 1 commit into
aidan-hall wants to merge 1 commit into
Conversation
In swiftlang#91813, we changed DeadObjectElimination to treat mark_dependence_addr as a load-like use of its address operand. This was the wrong approach, since mark_dependence_addr changes an attribute of the stored value (adding a dependence on the base operand), making it more like a store. Unlike store, it retains the original value at the address, so we treat it as its own combined load & store Access kind. This fixes the regressions introduced by swiftlang#91813, while retaining the desired behaviour. Fixes rdar://187806150, issue swiftlang#92448. Assisted-by: Claude Opus 5
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #91813, we changed DeadObjectElimination to treat
mark_dependence_addras a load-like use of its address operand. This was the wrong approach, sincemark_dependence_addrchanges an attribute of the stored value (adding a dependence on the base operand), making it more like a store. Unlike store, it retains the original value at the address, so we treat it as its own combined load & store Access kind.This fixes the regressions introduced by #91813, while retaining the desired behaviour.
Fixes rdar://187806150, issue #92448.
Assisted-by: Claude Opus 5