Skip to content

Run macOS root tests in separate CI job #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
broken-circle wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Run macOS root tests in separate CI job #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,42 @@ jobs:
done
# empty line to ignore the --swift-sdk given by swiftlang/github-workflows/.github/workflows/scripts/install-and-build-with-sdk.sh \

test_macos_root:
name: Test macOS (root)
runs-on: [self-hosted, macos, tahoe, ARM64]
timeout-minutes: 30
env:
DEVELOPER_DIR: /Applications/Xcode_26.4.app
ROOT_SUITE: SubprocessUnixRootTests
steps:
- name: Remove leftover root build
run: sudo -n rm -rf "${GITHUB_WORKSPACE}/.build-root" || true

- name: Checkout repository
uses: actions/checkout@v7

- name: Verify passwordless sudo
run: |
uid="$(sudo -n id -u)" || { echo "::error::passwordless sudo unavailable"; exit 1; }
[ "$uid" -eq 0 ] || { echo "::error::sudo did not elevate to root (uid=$uid)"; exit 1; }

- name: Build root test suite
run: sudo -n env DEVELOPER_DIR="$DEVELOPER_DIR" xcrun swift build --build-tests --scratch-path "${GITHUB_WORKSPACE}/.build-root"

- name: Discover root test suite
run: |
sudo -n env DEVELOPER_DIR="$DEVELOPER_DIR" xcrun swift test list --scratch-path "${GITHUB_WORKSPACE}/.build-root" > "$RUNNER_TEMP/root-list.txt"
count="$(grep -c "${ROOT_SUITE}/" "$RUNNER_TEMP/root-list.txt" || true)"
echo "discovered ${count} ${ROOT_SUITE} test(s)"
[ "${count:-0}" -ge 1 ] || { echo "::error::${ROOT_SUITE} not found"; cat "$RUNNER_TEMP/root-list.txt"; exit 1; }

- name: Run root test suite
run: sudo -n env DEVELOPER_DIR="$DEVELOPER_DIR" xcrun swift test --scratch-path "${GITHUB_WORKSPACE}/.build-root" --filter "$ROOT_SUITE"

- name: Clean up root test suite
if: always()
run: sudo -n rm -rf "${GITHUB_WORKSPACE}/.build-root" || true

test_linux_kernel:
name: Test Linux Kernel / ${{ matrix.dist-kern }}
runs-on: ubuntu-latest
Expand Down
17 changes: 11 additions & 6 deletions Tests/SubprocessTests/UnixTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ import System
import SystemPackage
#endif

@Suite(.serialized)
struct SubprocessUnixRootTests {
init() {
_ = globallyIgnoredSIGPIPE
}
}

@Suite(.serialized)
struct SubprocessUnixTests {
init() {
Expand All @@ -42,8 +49,7 @@ struct SubprocessUnixTests {
}

// MARK: - PlatformOption Tests
extension SubprocessUnixTests {
// Run this test with sudo
extension SubprocessUnixRootTests {
@Test(
.enabled(
if: getgid() == 0,
Expand All @@ -61,7 +67,6 @@ extension SubprocessUnixTests {
)
}

// Run this test with sudo
@Test(
.enabled(
if: getgid() == 0,
Expand All @@ -79,7 +84,6 @@ extension SubprocessUnixTests {
)
}

// Run this test with sudo
@Test(
.enabled(
if: getgid() == 0,
Expand Down Expand Up @@ -107,7 +111,6 @@ extension SubprocessUnixTests {
)
}

// Run this test with sudo
@Test(
.enabled(
if: getgid() == 0,
Expand Down Expand Up @@ -171,7 +174,9 @@ extension SubprocessUnixTests {
// PGID should == PID
#expect(match.output.pid == match.output.pgid)
}
}

extension SubprocessUnixTests {
@Test(
.enabled(
"This test requires ps (install procps package on Debian or RedHat Linux distros)",
Expand Down Expand Up @@ -893,7 +898,7 @@ extension SubprocessUnixTests {
}

// MARK: - Utils
extension SubprocessUnixTests {
extension SubprocessUnixRootTests {
private func assertID(
withArgument argument: String,
platformOptions: PlatformOptions,
Expand Down
Loading