Migrate to Vue 3 - #1025
Migrate to Vue 3#1025mchoo7 wants to merge 34 commits into
Conversation
|
Lots of lifting in this - I'm likely the last to provide useful feedback, but I went ahead and asked an LLM to look over the PR for any low-hanging fruit feedback that might help improve this if the DocC render maintainers are so inclined. From that output:
I stumbled over (note: I am not a maintainer on this project, more a very interested consumer of it) |
I don't see any change made to OverviewCard.
Updated
I was going to do ESLint (and Prettier) in a follow-up PR.
I don't see any failures. Could you share the error message please? |
Bug/issue #976 #977, if applicable:
Summary
As mentioned in #976, this project is currently using Vue 2. Not only this leaves bugs from dependencies (unless we patch against individual deps), using EOL-ed software leaves security holes that can be exploited in many ways, especially in these days where LLM can find dozens of security flaws in a few hours. After this change,
pnpm outdatedwill show nothing (there is deprecated package warning fromjs-beautify, but it's not our responsibility).Screenshot:
Notes
pnpm instsall && pnpm run docs"type": "module")Breaking Changes
For Users
There is no breaking changes for users at least according to the spec. The only pitfall here is the browerlist. Vite 8 has stricter browser compatibility then our current browserlist, but I'm pretty sure for generated code the old code is more compatible for (very) legacy browsers. For example, support for Internet Explorer is now fully dropped.
For Developers
serveis renamed todevto follow vite conventiondev(previouslyserve) is now 5173 (vite's default)VUE_APP_*is nowVITE_*(this is what vite expects)Future plans
I will do the following:
This PR is groundwork for the following optional improvements, but I won't or currently have no plan to do:
Dependencies
package.jsonwill allow Node 22, but if your node version manager(s) read.nvmrc, they will complain about it because.nvmrccannot store multiple major versions.@vue/compiler-sfcis added to replace its functionality.Testing
Invoking test is same as before, except that vitest is now the backend (it's easier to sync with vite and vue). However, changes to test files need to be reviewed for sure.
This needs to be tested with other documentations such as the Swift documentation or the Apple documentation. However, I don't know how to test against these and don't have time for that, so I hope Swift/Apple devs can do this for me.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
pnpm test, and it succeededFixes: #976
Fixes: #977