Display the OAuth2 Redirect URL in the authorization dialogue along side the existing URLs - #11040
Open
andrewnicols wants to merge 1 commit into
Open
Display the OAuth2 Redirect URL in the authorization dialogue along side the existing URLs#11040andrewnicols wants to merge 1 commit into
andrewnicols wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The OAuth2 Redirect URL defaults to a value, but can be overridden by the
oauth2RedirectUrlconfig parameter; however neither the default value nor the custom value are ever surfaced in the UI. The only way to find the currently used value is to attempt to authenticate, and grab the value from the URL.This change adds the current value of the OAuth2 Redirect URL to the Authorisation dialogue, just underneath the Authorization URL and Token URL values.
Motivation and Context
This change adds information which is otherwise difficult to find and makes it easier for users using a hosted Swagger UI where they are still responsible for configuring the client properly.
How Has This Been Tested?
Unit tests included.
Also tested manually with the local dev environment and checking that:
oauth2RedirectUrlsetScreenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests