Repository navigation
feat: add React 19 support to swagger-ui-react - #10542
Closed
felix-ebert wants to merge 1 commit into
Closed
felix-ebert wants to merge 1 commit into
felix-ebert wants to merge 1 commit into
Conversation
- Updated peer dependencies to support React 19.x - Changed React constraint from '>=16.8.0 <19' to '>=16.8.0 <20' - Updated both main package.json and React flavor template - All existing tests pass with React 19 support Fixes swagger-api#10243
felix-ebert
marked this pull request as ready for review
August 5, 2025 10:21
|
Nice to see the bump! Out of curiosity, has this been tested on React 19 yet, or is this mainly a peer dependency update for now? |
Contributor
|
Hi @felix-ebert, Thank You for this PR. However, with changes in package.json will also require change in its lock file. Can you please update that too. |
Contributor
|
Hi @felix-ebert, Thanks again for your contribution! I've created a superseding PR that includes your changes with proper attribution and updates the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the peer dependency constraints for React and React-DOM to support React 19.x versions. The changes modify both the main package.json and the React flavor template to expand the accepted React version range from
>=16.8.0 <19to>=16.8.0 <20, enabling compatibility with React 19 while maintaining backward compatibility with all previously supported React versions.Motivation and Context
Fixes #10243
How Has This Been Tested?
npm run test:unit)Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests