fix: explain the Follow log switch with a tooltip - #7145
Open
superplanehq-integration[bot] wants to merge 1 commit into
Open
superplanehq-integration[bot] wants to merge 1 commit into
superplanehq-integration[bot] wants to merge 1 commit into
Conversation
The Follow switch in the Automations log header had only the bare
label "Follow" with no explanation of what it does or why it
matters. Users could not tell that it auto-scrolls the log, and the
effect was invisible when the log was short or the run was idle.
Wrap the switch in a Tooltip that explains its purpose ("Auto-scroll
the log to the newest output.") and add a ChevronsDown icon as a
visual hint. The visible and accessible switch name stays "Follow"
so existing tests keep passing; Radix Tooltip already wires up
aria-describedby on the trigger automatically.
Add a test asserting the tooltip text appears on hover.
Signed-off-by: SuperPlane Agent <superplaneagent@superplane.com>
Co-authored-by: André Calil <andre@superplane.com>
Contributor
Author
|
👋 Commands for maintainers:
|
Contributor
Author
|
Maintainers: comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Follow toggle in the Automations log header showed only the bare
label "Follow", with no hint about what it does. Users could not tell
that it auto-scrolls the log to the newest output, and the effect was
invisible when the log was short or a run was not active.
This adds a tooltip to the existing Follow switch (
SplitRunLogHeader.tsx)explaining its purpose, plus a small
ChevronsDownicon as a visual hintthat it controls scroll position. The change is frontend-only and does
not touch the follow/auto-scroll logic in
useFollowLogScroll.ts/followLogScroll.ts.Because
SplitRunFollowSwitchis the shared control, both usages getthe fix:
WorkOrderSplitRunPopup.tsx(Automations tab)FactoryAppSplitRunPage.tsx(viaSplitRunLogHeader)The visible and accessible switch name stays
"Follow", so existingtests that query
getByRole("switch", { name: "Follow" })keeppassing unchanged. Radix's
Tooltip/TooltipTriggeralready wires uparia-describedbyon the trigger element automatically when thetooltip is open, so no extra ARIA wiring was needed.
Test plan
make format.jsmake check.lint.uimake check.build.uinpx vitest runfor thework-order-split-runfolder (357 testspass), including the new tooltip test in
WorkOrderSplitRun.follow.spec.tsxgetByRole("switch", { name: "Follow" })assertions in
WorkOrderSplitRun.spec.tsx,FactoryAppSplitRunPage.spec.tsx, andLinesPage.spec.tsxstillpass