fix(postgrest): align rpc maybe_single with select - #1555
Open
joaompneves wants to merge 2 commits into
Open
Conversation
Use MaybeSingleRequestBuilder for RPC instead of the Accept object+json header, so zero-row results return None like select. Co-authored-by: Cursor <cursoragent@cursor.com>
Assert select and rpc raise APIError 406 when more than one row is returned, for both sync and async builders. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rpc().maybe_single()use the sameMaybeSingleRequestBuilderpath asselect().maybe_single(), instead of settingAccept: application/vnd.pgrst.object+jsonNoneinstead of raising anAPIError, matching select behavior (follows fix(postgrest): fix maybe_single #1424)maybe_singlecasesFixes the remaining gap from #1107 / #1207 where select was fixed but RPC still used the old Accept-header approach.
Test plan
test_rpc_with_maybe_singlepasses (sync + async)test_rpc_with_maybe_single_no_matchreturnsNone(sync + async)test_rpc_with_singleand selectmaybe_singletests still passMade with Cursor