decode: show Bind result-column format codes - #8
Merged
Merged
Conversation
Bind was the one extended-query message with an unrendered field — result_column_format_codes (the text/binary format the client requested for the result columns). Show it after the params as `result: text` / `binary` / `[text, binary, ...]`. Parse already renders all its fields. Verified end to end: a psql \bind session decodes as Bind: <unnamed> <- <unnamed> params: [...] result: text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bindwas the only extended-query message with an unrendered field —result_column_format_codes, the text/binary format the client requested for theresult columns (i.e. the "format of output").
Parsealready renders all itsfields.
Change (
src/decode.rs)format_format_codes(&[i16])→ compacttext/binary/[text, binary, …].format_bindnow appends it:… params: [...] result: <fmt>.Example
An extended-query session (psql
\bind) through the mitm proxy:Verification
cargo fmt/clippy -D warnings/test(4/4) clean;nix buildandnix flake checkpass.\bindsession decodes withresult: textpresent.Note
This was originally committed straight onto
main; per request it's moved onto this branch for proper review. (Unrelated side note, not changed here: in that trace the param renders as hex3431because psql's\bindflags the parameter as binary format — existing behaviour, happy to look at separately.)