fix(homebrew): hoist url/sha256 so the formula loads on every platform - #323
Open
stuffbucket wants to merge 1 commit into
Open
stuffbucket wants to merge 1 commit into
stuffbucket wants to merge 1 commit into
Conversation
`brew tap` validates a tap against every platform it supports, including
arm64_linux. url/sha256 lived inside `on_macos do -> on_arm do`, so on Linux
those blocks did not apply and the formula had no URL:
Invalid formula (arm64_linux): bladerunner: formula requires at least a URL
A tap is all-or-nothing, so this stopped the ENTIRE stuffbucket/tap from
loading -- coop, vale and the claudeme cask were unusable because of it.
`depends_on :macos` / `depends_on arch: :arm64` do not prevent this: loading
happens before dependencies are evaluated. They are also already what restricts
installation to arm64 macOS, so the platform blocks were redundant as well as
harmful.
Verified with `brew readall --os=linux --arch=arm stuffbucket/tap`: two errors
before, clean after, with `brew info` still resolving 0.4.8 on macOS.
The release-please.yml renderer is pure PLACEHOLDER_* substitution, so it is
unaffected by the indentation change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formula template counterpart to stuffbucket/homebrew-tap#3.
brew tapvalidates a tap against every platform it supports, includingarm64_linux.url/sha256lived insideon_macos do → on_arm do, so on Linux those blocks did not apply and the rendered formula had no URL:A tap is all-or-nothing, so this stopped the entire
stuffbucket/tapfrom loading —coop,valeand theclaudemecask were unusable because of it.depends_on :macos/depends_on arch: :arm64do not prevent this: loading happens before dependencies are evaluated. They are also already what restricts installation to arm64 macOS, so the platform blocks were redundant as well as harmful.Verification
Rendered through
release-please.yml'ssedwith real release values, then validated withbrew readall(the same checkbrew tapperforms): 2 errors before, clean after, onlinux/arm,linux/inteland--os=all.brew infostill resolves 0.4.8 on macOS.release-please.yml'ssedis purePLACEHOLDER_*substitution, so it is unaffected by the indentation change.The tap repo's rendered copies were patched directly in stuffbucket/homebrew-tap#3 so the tap works without waiting for a release; this change keeps the next release from reverting it.
🤖 Generated with Claude Code