chore: Polish our code, fix typos, update readme#20
Open
michalurbanek wants to merge 2 commits intomasterfrom
Open
chore: Polish our code, fix typos, update readme#20michalurbanek wants to merge 2 commits intomasterfrom
michalurbanek wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on polishing documentation and comments, fixing typos, and making a few small behavior tweaks in the Flutter app startup/profile flows.
Changes:
- Clean up and clarify multiple README sections, CODEOWNERS, and localization strings.
- Adjust Landing/Profile logic (splash removal flow + profile image fallback handling).
- Minor build/config hygiene (build.yaml cleanup, iOS build phase script fixes, update comments/URLs).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| project_setup/README.md | Improves wording/clarity for setup steps. |
| makefile | Updates gen-l10n invocation (removes --no-synthetic-package). |
| lib/features/profile/profile_state.dart | Uses user image when available and falls back to a random image URL. |
| lib/features/landing/landing_page.dart | Refines mounted checks and splash removal timing before navigation. |
| lib/common/usecase/native_store_open_use_case.dart | Fixes/modernizes an exception doc comment. |
| lib/common/usecase/authentication/sign_in_completion_use_case.dart | Updates placeholder avatar URL to a concrete image URL. |
| lib/common/provider/firebase_messaging_service.dart | Fixes a typo in a comment. |
| lib/app/setup/setup_app.dart | Fixes cache-size comment text. |
| ios/Runner.xcodeproj/project.pbxproj | Fixes/clarifies Firebase plist copy + Crashlytics upload scripts (incl. staging message, missing commands). |
| build.yaml | Removes a duplicate entry and trims unused generator config. |
| assets/localization/app_en.arb | Fixes grammar in the force-update description string. |
| README.md | Broad documentation cleanup, improved instructions, corrected terminology. |
| .github/CODEOWNERS | Fixes formatting so owners actually apply (adds * pattern). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.