CryptoOnramp SDK: Splits Rich Error Types (SDK vs. API)#2495
Open
mliberatore wants to merge 7 commits into
Open
CryptoOnramp SDK: Splits Rich Error Types (SDK vs. API)#2495mliberatore wants to merge 7 commits into
mliberatore wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To more closely match the native SDKs, we're splitting the
OnrampApiErrortype to have a baseOnrampSdkErrorthat covers non-API errors.To maintain the existing "legacy" SDK error for attestation failures on
create/configure, and keepOnrampErrorTypenon-optional, we addLegacyConfigureAppAttestationErroruntil we have a concrete error type from the native SDKs (i.e. stripe/stripe-ios#6588).Motivation
#2485 (review)
Testing
Documentation
Select one: