refactor: remove duplicated code & split constraint solver - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors duplicated constraint, AST, source-position, and annotation helper logic into shared modules while preserving existing analyzer and LSP behavior.
Changes
Constraint solver modularization
Shared parser and AST helpers
SourceRangeand byte-offset helpers so analyzer, constraints, and server code no longer need local line/column conversion copies.AstNodehelpers for source ranges, statement/body traversal, child expression traversal, binding names, and target display.Comprehension::target_node, allowing destructuring bindings to use AST-backed extraction instead of string splitting when available.Analyzer, server, and core cleanup