fix stale helper exports for build plugins#14
Closed
jamilahmadzai wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Hello, I'm 🤖 Stormie-Bot! The Storm team sincerely appreciates your effort/interest in contributing to this project. A Storm developer will review this change and get back to you ASAP. Please feel free to reach out to the Storm team (contact@stormsoftware.com) if you have any questions/comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes stale helper subpath exports from the build plugin package manifests:
@powerlines/plugin-tsup@powerlines/plugin-vite@powerlines/plugin-tsdown@powerlines/plugin-esbuild@powerlines/plugin-rolldownThose package.json exports point at
dist/helpers/...files that are not present in the published packages or in these package source trees, so consumers can resolve a helper subpath and then fail at runtime withERR_MODULE_NOT_FOUND.The root exports,
./typesexports, and./package.jsonexports are unchanged.Reproduction
For example, with the current published
@powerlines/plugin-tsup@0.12.596package:import.meta.resolve()points todist/helpers/index.mjs, but that file is not included in the package, so importing it fails.Validation
./helpers*export keys.git diff --checkpnpm install --frozen-lockfile --ignore-scriptsI also attempted to run the
plugin-tsupVitest entry directly, but the test process stops during setup before executing tests because the installed@storm-software/tsuppackage imports@nx/js/src/utils/buildable-libs-utilswithout the.jsextension under this Node/ESM setup. This change is limited to package export metadata.