musl/OHOS compatibility: dlopen detection, _LARGEFILE64_SOURCE, config.guess - #1406
Open
wotomchen wants to merge 2 commits into
Open
musl/OHOS compatibility: dlopen detection, _LARGEFILE64_SOURCE, config.guess#1406wotomchen wants to merge 2 commits into
wotomchen wants to merge 2 commits into
Conversation
added 2 commits
June 24, 2026 14:55
The AC_DEFINE macros for HAVE_LROUND, HAVE_LLROUND, HAVE_NAN, HAVE_FMIN, HAVE_FMAX, and UINT64_T_AND_ULONG_SAME lack AH_TEMPLATE declarations, causing autoheader to fail with newer autoconf versions. Add the corresponding AH_TEMPLATE calls so autoheader can generate proper config.h.in templates. Also add the missing #undef entries to the hand-maintained config.h.in to match.
…fig.guess * configure.ac: Check for dlopen in libc before trying -ldl. On musl (and OpenHarmony), dlopen is part of libc with no separate libdl. * configure.ac: Add _LARGEFILE64_SOURCE fallback detection for fopen64. On musl, fopen64 needs this define to be declared; glibc exposes it via _LARGEFILE_SOURCE alone. * config.guess: Recognize HarmonyOS uname -s output and canonicalize as *-unknown-linux-ohos.
Collaborator
|
This pull request also includes the |
Collaborator
|
Are you planning to push these changes to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes for musl libc and OpenHarmony (OHOS) compatibility:
dlopen detection - Check for dlopen in libc before trying -ldl. On musl (and OHOS), dlopen is part of libc with no separate libdl.
_LARGEFILE64_SOURCE fallback - On musl, fopen64 needs _LARGEFILE64_SOURCE to be declared; glibc exposes it via _LARGEFILE_SOURCE alone. Add a fallback check so fopen64 is found on musl.
config.guess OHOS detection - Recognize HarmonyOS from uname -s and canonicalize as *-unknown-linux-ohos.