Fix schedule race cond which causes a hang - #61
Merged
Merged
Conversation
nitely
changed the title
nitely
force-pushed
the
fix_schedule_wait
branch
from
August 13, 2026 19:02
dbc948b to
8211a95
Compare
nitely
marked this pull request as ready for review
August 13, 2026 19:03
nitely
enabled auto-merge (squash)
August 13, 2026 19:03
nitely
disabled auto-merge
August 13, 2026 19:05
nitely
enabled auto-merge (squash)
August 13, 2026 19:06
nitely
disabled auto-merge
August 13, 2026 19:18
nitely
force-pushed
the
fix_schedule_wait
branch
from
August 13, 2026 19:22
8211a95 to
a7190c3
Compare
nitely
enabled auto-merge (squash)
August 13, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix peek+push schedule race cond (which causes a hang) by doing peek, push, then re-check whether the queue got drained in between. Remove
peekand move the check insidepushto keep the same perf.I submitted the fix to constantine as well mratsim/constantine#630