Unify e2e yardstick backend on 1.2.0 - #6004
Merged
Merged
Conversation
#5981 temporarily split the yardstick image -- Legacy 1.1.1 for the operator/vMCP suites, Modern 1.2.0 only for the dual-era tests -- because the vMCP classified a session-mode v1.7 backend as Modern (from a server/discover 200) and could not drive it. #5993 fixed that: the vMCP now keys classification on server/discover's supportedVersions, so a session-mode v1.7 backend (which omits 2026-07-28) is correctly classified Legacy and driven via the Legacy data plane. With that in main, the split is no longer needed. Collapse back to a single YardstickServerImage at 1.2.0 for every e2e suite, drop the YardstickServerImageDualEra constant, and unify the workflow pulls/loads. Verified: TestProbeRevision_RealBackends (a real session-mode go-sdk v1.7 backend classifies Legacy) passes on main, and the dual-era e2e suite passes locally on the unified 1.2.0 image. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jhrozek
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
aponcedeleonch,
blkt,
jerm-dro,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
July 27, 2026 09:33
JAORMX
approved these changes
Jul 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6004 +/- ##
==========================================
- Coverage 72.05% 72.05% -0.01%
==========================================
Files 720 720
Lines 74641 74680 +39
==========================================
+ Hits 53786 53814 +28
- Misses 17001 17012 +11
Partials 3854 3854 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5981 and #5993.
Summary
Why: #5981 temporarily split the e2e yardstick backend image — Legacy
1.1.1for the operator/vMCP suites, Modern1.2.0only for the dual-era tests — because the vMCP classified a session-mode go-sdk v1.7 backend as Modern (from aserver/discover200) and then could not drive it (Modern data-plane calls returnerrWrongEra). #5993 fixed that: the vMCP now keys revision classification onserver/discover'ssupportedVersions, so a session-mode v1.7 backend — whosesupportedVersionsomits2026-07-28— is correctly classified Legacy and driven via the Legacy data plane. With #5993 inmain, the split is no longer needed.What: collapse back to a single
images.YardstickServerImageat1.2.0for every e2e suite, drop the temporaryYardstickServerImageDualEraconstant, and unify the workflow image pulls/loads (net −11 lines).Type of change
Test plan
task test):TestProbeRevision_RealBackends(the Support MCP 2026-07-28 spec (go-sdk v1.7 via toolhive-core) #5993 anti-regression pin — a real session-mode go-sdk v1.7 backend must classify Legacy) passes onmain, confirming a 1.2.0 backend in session mode is driven Legacy by the vMCP.task test-e2e): thedual-erasuite passes locally on the unified 1.2.0 image (11/11). The vMCP/virtualmcp/operator suites on 1.2.0 are gated by this PR's CI (E2E Tests Core (vmcp),E2E Test Lifecycle).Does this introduce a user-facing change?
No.
Generated with Claude Code