Configure SSH AllowUsers on Rocky Linux 10 - #2471
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughConfigures Rocky Linux 10 CIS hardening to preserve SSH access for the bootstrap, kolla, and stack users, preventing WalkthroughRocky 10 CIS hardening now allows SSH access for ChangesRocky 10 SSH allowlist
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Comment |
Without this setting, only the user applying CIS benchmark hardening was authorised to log in, breaking the growroot.yml playbook.
86fa0ad to
b5f479e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a70276f2-5c9b-47a5-a402-314651951fb1
📒 Files selected for processing (2)
etc/kayobe/inventory/group_vars/cis-hardening/cisreleasenotes/notes/rhel10cis-sshd-allowusers-60e902bfbd8b6c16.yaml
📜 Review details
⏰ Context from checks skipped due to timeout. (5)
- GitHub Check: Tox releasenotes with Python 3.12
- GitHub Check: Tox docs with Python 3.12
- GitHub Check: Ansible 2.18 lint with Python 3.12
- GitHub Check: Tox pep8 with Python 3.12
- GitHub Check: Ansible 2.17 lint with Python 3.10
🔇 Additional comments (1)
etc/kayobe/inventory/group_vars/cis-hardening/cis (1)
152-154: LGTM!
| Configures Rocky Linux 10 CIS benchmark hardening to allow SSH for users | ||
| ``cloud-user``, ``kolla`` and ``stack``. This resolves issues with running | ||
| the ``growroot.yml`` playbook after applying hardening configuration. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Document the configurable bootstrap user instead of hard-coding cloud-user.
The configuration allows {{ bootstrap_user }}, not necessarily cloud-user; use “the bootstrap user” (or bootstrap_user) in this note, and remove the extra space before stack.
Suggested wording
- ``cloud-user``, ``kolla`` and ``stack``. This resolves issues with running
+ the bootstrap user, ``kolla`` and ``stack``. This resolves issues with running📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Configures Rocky Linux 10 CIS benchmark hardening to allow SSH for users | |
| ``cloud-user``, ``kolla`` and ``stack``. This resolves issues with running | |
| the ``growroot.yml`` playbook after applying hardening configuration. | |
| Configures Rocky Linux 10 CIS benchmark hardening to allow SSH for users | |
| the bootstrap user, ``kolla`` and ``stack``. This resolves issues with running | |
| the ``growroot.yml`` playbook after applying hardening configuration. |
Without this setting, only the user applying CIS benchmark hardening was authorised to log in, breaking the growroot.yml playbook.