2026.1: remove references to RL9 from etc/kayobe/ - #2468
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe configuration removes Rocky Linux 9-specific playbooks, repositories, hardening settings, image versions, and release variables, while updating automation, runtime, vulnerability detection, and package configuration for Rocky Linux 10 and the 2026.1 release. ChangesRocky Linux 10 transition
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
e957ac9 to
75f96cb
Compare
75f96cb to
9aeb82c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@etc/kayobe/environments/ci-tenks/automated-deployment.sh`:
- Around line 13-14: Update the existing checkout handling in
automated-deployment.sh so reruns synchronize $HOME/src/kayobe-config with
KAYOBE_CONFIG_REF and $HOME/src/kayobe with KAYOBE_BRANCH, rather than skipping
fetch/checkout when directories already exist. Fetch the requested refs and
check them out, or fail fast if the existing clones cannot match the requested
refs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 628a279a-1512-4476-9795-d344321c4930
📒 Files selected for processing (23)
etc/kayobe/ansible/fixes/fix-grub-rl9.ymletc/kayobe/ansible/maintenance/cis.ymletc/kayobe/ansible/maintenance/rocky-97-ofed-upgrade.ymletc/kayobe/ansible/requirements.ymletc/kayobe/dnf.ymletc/kayobe/environments/aio/automated-setup.shetc/kayobe/environments/aio/globals.ymletc/kayobe/environments/aio/inventory/group_vars/cis-hardening/cisetc/kayobe/environments/aio/kolla/config/nova/nova-compute.confetc/kayobe/environments/aio/release-train.ymletc/kayobe/environments/ci-builder/stackhpc-ci.ymletc/kayobe/environments/ci-multinode/inventory/group_vars/cis-hardening/cisetc/kayobe/environments/ci-multinode/stackhpc-ci.ymletc/kayobe/environments/ci-tenks/automated-deployment.shetc/kayobe/inventory/group_vars/cis-hardening/cisetc/kayobe/inventory/group_vars/controllers/cisetc/kayobe/inventory/group_vars/wazuh-manager/wazuh-manageretc/kayobe/kolla.ymletc/kayobe/ofed.ymletc/kayobe/pulp-host-image-versions.ymletc/kayobe/pulp-ipa-image-versions.ymletc/kayobe/stackhpc-overcloud-dib.ymletc/kayobe/stackhpc.yml
💤 Files with no reviewable changes (13)
- etc/kayobe/ansible/fixes/fix-grub-rl9.yml
- etc/kayobe/inventory/group_vars/controllers/cis
- etc/kayobe/ansible/maintenance/rocky-97-ofed-upgrade.yml
- etc/kayobe/environments/ci-multinode/inventory/group_vars/cis-hardening/cis
- etc/kayobe/stackhpc.yml
- etc/kayobe/ansible/requirements.yml
- etc/kayobe/kolla.yml
- etc/kayobe/pulp-host-image-versions.yml
- etc/kayobe/environments/aio/inventory/group_vars/cis-hardening/cis
- etc/kayobe/ofed.yml
- etc/kayobe/inventory/group_vars/cis-hardening/cis
- etc/kayobe/environments/ci-builder/stackhpc-ci.yml
- etc/kayobe/environments/aio/release-train.yml
|
Aren't we going to have lots of merge conflicts once we merge this? Should we wait until we stop making so many changes to stackhpc/2025.1? |
I'd say we should make 2026.1 the new main branch and start pushing features to it rather than 2025.1 now |
| ############################################################################### | ||
| # Kolla image build configuration. | ||
|
|
||
| # Repositories for Rocky Linux 10 |
There was a problem hiding this comment.
Do we not need these then?
Looks like they came via:
8df7484
There was a problem hiding this comment.
I believe these definitions were only for kolla image builds, and in Gazpacho we can do that centrally in repos.yaml
Removing RL9 references from the etc/kayobe/ directory
This should be everything except the ipa image config, which we're waiting on some fixes for right now. It'll be forward-ported from Epoxy once it merges there
Summary by CodeRabbit
New Features
Configuration Updates
Removed