Repository navigation
Conversation
Member
|
Thanks for opening this @keewis! I like the separate modules a lot. |
Member
|
Having started looking through this a bit I'm wondering if this could be an opportunity to use pystac extension classes rather than parsing the json. |
Contributor
Author
|
most likely. I had a look at this when I implemented this a couple of months ago but decided it was too complicated at the time: AFAIR a alternate asset extension didn't exist back then (I didn't check if it does now), and implementing it myself took more than the little mental capacity I had at the time. Once that exists, though, I'd be happy to change the PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xpystacused to rely mainly on thexarraySTAC extension to infer any additional parameters needed to open the data. That extension has been superseded by thestorageandauthextensions, and additionally there are now additional extensions like thealternateextension with additional ways to describe metadata needed to open the data.This mainly adds infrastructure to extract the metadata, there still needs to be a translation layer that converts to xarray options.
Checklist
README.mdto reflect any new environment variables, configuration changes, or breaking updates.AI tool usage
none, all hand-written.