Server-side download URL generation#1438
Open
ponyisi wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1438 +/- ##
===========================================
+ Coverage 88.91% 89.36% +0.45%
===========================================
Files 103 104 +1
Lines 3679 3921 +242
Branches 454 494 +40
===========================================
+ Hits 3271 3504 +233
- Misses 333 342 +9
Partials 75 75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ponyisi
force-pushed
the
server-url-generation
branch
from
c75c2e9 to
31f7365
Compare
MattShirley
reviewed
May 18, 2026
MattShirley
reviewed
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass at generating download URLs for ServiceX output on the server side. The client can request a list of files in a transform, and URLs will be returned.
We have a hook here for doing this with other backends, e.g. xrootd-based ones. At some point we also probably want to cache results for some length of time.