Repository navigation
Conversation
…t cannot be deserialized. A publication whose event fails to deserialize throws when registered as in progress. Unregistering it in the catch block deserialized the event again and let that exception escape, which aborted the resubmission and, with republish-outstanding-events-on-restart enabled, the application startup. We now only unregister publications that were actually registered. Signed-off-by: AdzerKI <silver_cat@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1904.
DefaultEventPublicationRegistry.processPublications(…)unregistered a publication in its catch block even if registering it had failed. For a JDBC publication whose event can't be deserialized, registering already throws, and unregistering deserializes the event again, so the second exception escaped the catch block. That aborted the resubmission run and, withrepublish-outstanding-events-on-restartenabled, the application startup.The catch block now only unregisters a publication that was actually registered. A publication whose event can't be deserialized is logged like any other failed resubmission, and the remaining publications of the run are still resubmitted.
Covered by a new test in
DefaultEventPublicationRegistryUnitTests, thespring-modulith-events-coretest suite passes.