Repository navigation
Fix collect() returning Eloquent Collection of Data objects - #1219
Open
tareq-halaby wants to merge 1 commit into
Open
tareq-halaby wants to merge 1 commit into
tareq-halaby wants to merge 1 commit into
Conversation
Eloquent\Collection assumes Model items (loadMissing, etc.). Mapping to Data objects and keeping the Eloquent collection type crashes callers on Laravel 12.27+. Align with Laravel map()/toBase() unless into is explicit. Fixes spatie#1212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1212.
Data::collect(Model::all())was returningEloquent\Collection<Data>. Since Laravel 12.27,loadMissing()on that collection crashes withCall to undefined method ...Data::newQueryWithoutRelationships().Laravel's own
Collection::map()already switches Eloquent collections to a baseSupport\Collectiononce items are no longer models. This PR does the same when\$intois omitted.Explicit
collect(\$items, EloquentCollection::class)still works for callers that want the Eloquent type.Test plan
into: EloquentCollection::classstill returns Eloquent