Feat/gelu f16 lut - #2687
Open
kali wants to merge 2 commits into
Open
Conversation
GeluApproximate's f16 arm ran an inline scalar loop rather than calling ops().gelu_f16, so the linalg f16 GELU slot was dead on every architecture. Route the canonical pow=3 path through the dispatcher, and make the generic f16 kernel a table over all 65536 f16 bit patterns built from the same scalar expression the existing kernel evaluates, so the table is bit-identical to it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ElementWiseKer::run is used unconditionally (HGelu8, HGeluLut8) but the trait import was gated behind target_arch = "aarch64", breaking the build everywhere else.
|
Reference: 2026-08-20 morning nightly run (0d old) · full report → run Speed — evaltime · prefill · decode no inference-speed regressions
|
| Δ | metric | device | main → PR |
|---|---|---|---|
| hey_snips_v4_model17 load · pulse8 |
cortex-a9 |
6.07 s → 7.29 s | |
| hey_snips_v4_model17 load+optimize · pulse8 |
cortex-a9 |
6.66 s → 7.88 s | |
| arm_ml_kws_cnn_m load · pass |
cortex-a9 |
83 ms → 97 ms | |
| arm_ml_kws_cnn_m load · pass |
cortex-a7 |
76 ms → 86 ms | |
| arm_ml_kws_cnn_m load+optimize · pass |
cortex-a9 |
128 ms → 143 ms | |
| arm_ml_kws_cnn_m load+optimize · pass |
cortex-a7 |
115 ms → 128 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@czoli1976. I had to revert #2568, the new test was tripping on avx512f.