ssh device: run pre/post commands around the runnable - #269
Merged
Conversation
fredszaq
approved these changes
Aug 19, 2026
There was no way to snapshot device state (cpu freq, load) right around an ssh-device run without wrapping the whole invocation externally. Add pre_run_commands/post_run_commands lists to SshDeviceConfiguration, spliced into the same remote shell invocation; the runnable's own exit status is preserved through $RC regardless of what either hook returns. Empty lists contribute no segment, so a device with neither configured gets the exact same command as before.
kali
force-pushed
the
ssh-device-pre-post-run-command
branch
from
August 19, 2026 12:34
cbd056d to
6c19828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no way to snapshot device state (cpu freq, load) right around an ssh-device run without wrapping the whole invocation externally. Add pre_run_commands/post_run_commands lists to SshDeviceConfiguration, spliced into the same remote shell invocation; the runnable's own exit status is preserved through $RC regardless of what either hook returns. Empty lists contribute no segment, so a device with neither configured gets the exact same command as before.