Repository navigation
[ci, client-js] Test local SDK proofs against the Agave validator - #581
Conversation
6c22eca to
5586dad
Compare
| rust-packages: ${{ needs.set_env.outputs.RUST_PACKAGES }} | ||
| wasm-packages: ${{ needs.set_env.outputs.WASM_PACKAGES }} | ||
| wasm-js-packages: ${{ needs.set_env.outputs.WASM_JS_PACKAGES }} | ||
| wasm-pack: ${{ needs.set_env.outputs.WASM_PACK == 'true' }} |
There was a problem hiding this comment.
Let's just hardcode this to true and avoid the other boilerplate is in this file 😅
There was a problem hiding this comment.
Yeah I did this for consistency, but I guess just true is fine here 😅
| lint-js-%: | ||
| cd $(call make-path,$*) && pnpm install && pnpm lint $(ARGS) | ||
|
|
||
| test-js-clients-js: build-wasm-js-node-zk-sdk-wasm-js |
There was a problem hiding this comment.
Is this still running the tests?
There was a problem hiding this comment.
Since test-js-clients-js has no recipe, I believe Make picks up the recipe from test-js-%, which I can verify. This can still be confusing though I agree, so I made the test commands explicit here. let me know what you think.
There was a problem hiding this comment.
Oh gotcha, that's cool! I had no idea that Make did that. Feel free to leave it as it was if you prefer then
81af044 to
b954b5c
Compare
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me once the merge conflicts are resolved!
b954b5c to
b4b4674
Compare
2 participants
Problem
I realized this as I was reviewing #360, but currently, the client integration tests use the published
@solana/zk-sdkpackage instead of using the local build. This means that the current CI do not verify that proofs generated by local zk-sdk changes are accepted in the tests.Summary of Changes
I updated so that:
@solana/zk-sdkworkspace package for client testswasm-packin the shared CI and JS publishing workflowsThe current CI workflow doesn't allow us to cleanly test locally built wasm packages for testing (the shared js test job needs rust and
wasm-packto build the local zk-sdk), so I created solana-program/actions#66 upstream, which will need to be merged before this.