feat(ios): bring the example Text screen to RN parity - #697
Open
maksg wants to merge 2 commits into
Open
Conversation
Port the react-native-example TextScreen behaviors that the native package supports: superscript/subscript md4c flags, a link-press alert with Open in Browser/Cancel instead of opening links directly, the RN selection color (#5A52FA), and a TaskList theme block matching the RN example's taskList style so the new checkboxes render with the same colors and geometry. Also fixes literal backslash-dollar escapes that were copied verbatim from the RN sample's template literal into the sample document's JS code block. Custom context menu items and display math are not ported: the package has no custom selection-menu API and no math renderer yet. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…es it AppShell loaded sample_markdown.md in onAppear, but the navigationDestination closure could build TextScreen from a stale view value captured while the state was still empty, leaving the Text screen permanently blank (deterministic on the iOS 27 simulator, intermittent on 26.5). Initialize the state from the bundle directly so every destination sees the loaded document. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
eszlamczyk
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Testing
PR Checklist