Single Quotes for COLLATE statements (New PR)#358
Open
YYYasin19 wants to merge 3 commits into
Open
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
My initial idea was to write a test that validates if the column is sorted according to the specified collation. |
Author
|
@sfc-gh-mkeller do you have some time or know someone from snowflake who could have a look at this? |
|
Just checking to see if there is an update on this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
This solves the issue described in Single quotes for the COLLATE statement #186, unfortunately, there was no issue referenced there.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
The initial problem description can be viewed here.
TL;DR:
When creating tables with columns that have collation in sqlalchemy
the resulting SQL statements use double quotes
which is allowed in other database engines but does not work in snowflake.
This PR fixes that issue by overwriting the rendering in the SQLAlchemy statement Compiler for text columns and adding at least one new test.