Skip to content

Fix: fixed unnecessary issue and empty cookie issue.#9

Open
DebanKsahu wants to merge 6 commits into
snj07:mainfrom
DebanKsahu:fix/core_network
Open

Fix: fixed unnecessary issue and empty cookie issue.#9
DebanKsahu wants to merge 6 commits into
snj07:mainfrom
DebanKsahu:fix/core_network

Conversation

@DebanKsahu

@DebanKsahu DebanKsahu commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • I added a property named avoidRetryOnThrowable, which is a set containing KClass of type Throwable (As a base inheritance). Just like previously it checked if a status code is eligible for retry or not, it will also check if a throwable is not available for retry.
  • To fix empty cookie error, I reversed the check order, previously it first checked is the cookie list empty or not then it creates header using only available cookies. Now it checks if the list of available cookies is empty or not, if not then it builds cookie header.
  • Fixed the ImportExportFixturesIntegrationTest test.

Scope

  • Modules touched: core-network, ui-desktop
  • Platform impact: All

Checklist

  • I have run relevant local checks (for example):
    • ./gradlew :ui-shared:allTests --no-daemon
    • ./gradlew :ui-desktop:desktopTest --no-daemon
    • ./gradlew :qa-tests:jvmTest --no-daemon
  • CI passes
  • I updated documentation if needed
  • No secrets committed

Related issues

Resolves: #7 , #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary retries for certain errors

1 participant