Conversation
- Fix a bug with `refineChromPeaks()` and `MergeNeighboringPeaksParam` which caused completely overlapping peaks not to be combined if they had the same `"rtmin"`, but the first peak had a smaller `"rtmax"` then the second (issue #825).
Collaborator
Author
|
Note: the same fix for Bioconductor 3.22 is in PR #827 |
sneumann
approved these changes
Feb 19, 2026
sneumann
left a comment
sneumann
left a comment
Owner
There was a problem hiding this comment.
Looks great, thanks for fixing ! Yours, Steffen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #825 , i.e., solves an issue that can cause completely overlapping chromatographics to be not merged by
refineChromPeaks()withMergeNeighboringPeaksParam.