Skip to content

[CRE-5456] Cache trigger subscription payloads - #23774

Open
bolekk wants to merge 1 commit into
developfrom
CRE-5456-cache-trigger-subs
Open

bolekk wants to merge 1 commit into
developfrom
CRE-5456-cache-trigger-subs

Conversation

@bolekk

@bolekk bolekk commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Optimization to avoid executing all WASM workflows on node boot just to get trigger sub payloads.

Assumptiona:

Additionally treat empty subscriptions as a non-retriable user error.

Change under a TOML config flag. I used TOML instead of cresettings for two reasons:

  • Flipping the flag requires a restart.
  • Rollout will be safer per-node rather than per-org.

Deployment Validation:

  1. None at image rollout - feature is off by default.
  2. After enabling the flag:
  • verify the number of active workflows hasn't changed and the number of failed registrations didn't go up.
  • check for improvements in startup time.

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@bolekk
bolekk force-pushed the CRE-5456-cache-trigger-subs branch 2 times, most recently from 5189924 to 79e056b Compare September 19, 2026 03:49
@bolekk
bolekk marked this pull request as ready for review September 20, 2026 20:54
@bolekk
bolekk requested review from a team as code owners September 20, 2026 20:54
@bolekk
bolekk enabled auto-merge September 21, 2026 19:21
@bolekk
bolekk force-pushed the CRE-5456-cache-trigger-subs branch from 79e056b to 391be44 Compare September 25, 2026 04:13
@bolekk
bolekk marked this pull request as draft September 25, 2026 16:58
auto-merge was automatically disabled September 25, 2026 16:58

Pull request was converted to draft

@bolekk bolekk changed the title CRE-5456: Cache trigger subscription payloads [CRE-5456] Cache trigger subscription payloads Oct 4, 2026
@bolekk
bolekk force-pushed the CRE-5456-cache-trigger-subs branch 3 times, most recently from 57d1c08 to b96ad60 Compare October 4, 2026 21:46
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@bolekk
bolekk force-pushed the CRE-5456-cache-trigger-subs branch from b96ad60 to b60fc42 Compare October 4, 2026 22:02
@cl-sonarqube-production

Copy link
Copy Markdown

@bolekk
bolekk marked this pull request as ready for review October 4, 2026 22:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants