Skip to content

[DX-3584] Run smoke tests after releasing an image#22035

Open
Tofel wants to merge 3 commits intodevelopfrom
dx-3584-post-build-tests
Open

[DX-3584] Run smoke tests after releasing an image#22035
Tofel wants to merge 3 commits intodevelopfrom
dx-3584-post-build-tests

Conversation

@Tofel
Copy link
Copy Markdown
Contributor

@Tofel Tofel commented Apr 16, 2026

When a new image has been published we will now run:

  • CRE smoke tests
  • CRE regression tests
  • legacy smoke tests

Example run via "hacked" Docker Build ✅ :

  • no problems with permissions
  • correct image was resolved and used in tests
image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

✅ No conflicts with other open PRs targeting develop

@Tofel Tofel force-pushed the dx-3584-post-build-tests branch from 9e5c002 to 93ffc8c Compare April 16, 2026 08:45
@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 16, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@Tofel Tofel force-pushed the dx-3584-post-build-tests branch from 93ffc8c to 452b43d Compare April 16, 2026 09:57
@Tofel Tofel marked this pull request as ready for review April 16, 2026 11:10
@Tofel Tofel requested a review from a team as a code owner April 16, 2026 11:10
Copilot AI review requested due to automatic review settings April 16, 2026 11:10
@Tofel Tofel requested review from a team as code owners April 16, 2026 11:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM

Adds post-release validation by running multiple system test suites against the newly published Chainlink image.

Changes:

  • Replaces the existing post-build workflow interface to accept a core image tag input and adds jobs for legacy + CRE smoke/regression suites.
  • Updates the build/publish pipeline to call the new post-build publish workflow after the core image build.
  • Minor workflow UX improvement by naming the devenv compatibility job.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/post-build-publish.yml Renames workflow and inputs; adds legacy + CRE smoke/regression reusable-workflow invocations.
.github/workflows/build-publish.yml Switches post-build to call post-build-publish.yml and passes the image identifier.
.github/workflows/devenv-compat.yml Adds an explicit job name for easier run readability.

Scrupulous human review focus (high-impact areas):

  • The new “image identifier” contract (chainlink_core_image_tag / chainlink_image_tag) and how it is resolved into an actual Docker image reference across all invoked reusable workflows.
Comments suppressed due to low confidence (3)

.github/workflows/post-build-publish.yml:10

  • The input description has a typo ("tagto"). Please correct it to improve readability (e.g., "image tag to use for the tests").
    .github/workflows/post-build-publish.yml:9
  • chainlink_core_image_tag is declared as required: false but it is passed directly into downstream reusable workflows as chainlink_image_tag, where it is required and ultimately used to resolve/pull the Chainlink image. If this input is omitted/empty, these jobs will fail at runtime. Consider making this input required (or giving it a default), or guard the test jobs with an if: inputs.chainlink_core_image_tag != '' condition.
    .github/workflows/post-build-publish.yml:74
  • chainlink_image_tag is being set to a tag|digest string (e.g., v2.3.4|sha256:...). The downstream workflows resolve the image by concatenating ...:${CHAINLINK_IMAGE_TAG} (see .github/scripts/resolve-chainlink-image.sh), which would yield an invalid Docker reference because | is not allowed in image tags. To ensure the tests pull the intended published image, pass only the tag here, or switch the contract to pass a full image reference that uses the standard digest syntax (repo@sha256:... or repo:tag@sha256:...) and update the resolver accordingly.

Comment thread .github/workflows/build-publish.yml Outdated
@Tofel
Copy link
Copy Markdown
Contributor Author

Tofel commented Apr 17, 2026

Superseded by #22063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants